Keep camera-view controls from interacting with the world#562
Open
frostdev-ops wants to merge 3 commits into
Open
Keep camera-view controls from interacting with the world#562frostdev-ops wants to merge 3 commits into
frostdev-ops wants to merge 3 commits into
Conversation
frostdev-ops
marked this pull request as ready for review
July 11, 2026 18:58
frostdev-ops
force-pushed
the
fix/camera-view-input
branch
from
July 15, 2026 09:38
82d2d4d to
bfcffec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #337
While using a monitor, the camera controls were still reaching Minecraft's normal interaction code. Looking down and holding left click could break the camera or another block, and held right click could activate the camera and print its status in chat.
This keeps camera mode isolated in three small pieces:
The hand-rendering change is deliberately kept in its own commit (
a7867571), so it can be dropped or reverted independently if that visual change is not wanted.I left the existing camera polling behavior alone. Zoom and exit still use the same short hold, including the startup delay that prevents the click used to open the monitor from immediately closing it again. Laser-camera firing remains on the Space key and its packet path is unchanged.
Tested with Forge 1.12.2:
test NO-SOURCE)