Skip to content

Keep camera-view controls from interacting with the world#562

Open
frostdev-ops wants to merge 3 commits into
LemADEC:MC1.12from
frostdev-ops:fix/camera-view-input
Open

Keep camera-view controls from interacting with the world#562
frostdev-ops wants to merge 3 commits into
LemADEC:MC1.12from
frostdev-ops:fix/camera-view-input

Conversation

@frostdev-ops

Copy link
Copy Markdown

Fixes #337

While using a monitor, the camera controls were still reaching Minecraft's normal interaction code. Looking down and holding left click could break the camera or another block, and held right click could activate the camera and print its status in chat.

This keeps camera mode isolated in three small pieces:

  • consume left- and right-mouse events only while the camera overlay is active
  • stop cancelable player interactions from reaching blocks, entities, or items while viewing a camera
  • hide the player's hand during the camera view

The hand-rendering change is deliberately kept in its own commit (a7867571), so it can be dropped or reverted independently if that visual change is not wanted.

I left the existing camera polling behavior alone. Zoom and exit still use the same short hold, including the startup delay that prevents the click used to open the monitor from immediately closing it again. Laser-camera firing remains on the Space key and its packet path is unchanged.

Tested with Forge 1.12.2:

  • reproduced the block breaking on the original jar
  • confirmed camera controls no longer affect blocks or print camera status in chat
  • confirmed normal interaction returns after leaving the camera view
  • verified the laser-camera Space-key targeting path is unchanged
  • built successfully offline with Java 8 (test NO-SOURCE)

@frostdev-ops
frostdev-ops marked this pull request as ready for review July 11, 2026 18:58
@frostdev-ops
frostdev-ops force-pushed the fix/camera-view-input branch from 82d2d4d to bfcffec Compare July 15, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Camera w/ monitor

1 participant